Repository navigation
feat(eval): warn when a trajectory_id appears more than once in a run - #41
Merged
Merged
Conversation
One trajectory_id is one conversation, but nothing checked that a run holds it once. A writer that adds a restarted conversation's row beside the earlier one gives it two rows, and eval scores both, so it counts twice. `usersim eval` now reads every row's id before any sampling and logs one warning naming the repeated ids, up to five, with their row counts. Rows are still evaluated as they are. `docs/outputs.md` states the convention: one id per conversation per run, derived from what the conversation stands for, not from the attempt, with a restart replacing its row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: isarasua <isarasua@nvidia.com>
… setup Signed-off-by: Yev Meyer <ymeyer@nvidia.com>
3mei
self-requested a review
October 14, 2026 13:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
One
trajectory_idis one conversation, but nothing checked that a run holds it once. A writer thatadds a restarted conversation's row beside the earlier one gives it two rows, and
usersim evalscores both, so it counts twice. Now eval warns, naming the ids:
--num-recordsor--num-records-per-localestill sees a repeat outside its sample. It names up tofive ids and counts the rest.
docs/outputs.mdstates the convention: one id per conversation per run, derived fromwhat the conversation stands for, not from the attempt. A restart replaces its row. It also says what eval does with a repeat.
Closes #40
How it was verified
tests/test_cli_eval_sampling.py:--num-records 1and--num-records-per-locale 1, and every row is still evaluated_choose_rowsfails its cases.make check-all,make check-license-headersandmake check-doc-linkspass.🤖 Generated with Claude Code