Repository navigation
fix: report health-check failures instead of skipping them - #58
Draft
binaryaaron wants to merge 1 commit into
Draft
binaryaaron wants to merge 1 commit into
binaryaaron wants to merge 1 commit into
Conversation
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid model configuration currently looks like missing credentials, and the scheduled health job masks provider failures. Skip only absent credentials; fail on configuration, execution, timeout, or missing-output errors.
Move the existing one-row simulate/eval/report recipe into a small Python runner that reuses CLI configuration and environment helpers. Keep Make as the entry point and report the outcome in the workflow summary.
Validation: 20 focused offline tests passed; changed-file Ruff lint and formatting, Make dry-run, and whitespace checks passed. No live provider calls were made.
Standalone replacement for the health-check portion of #46, based directly on main. Draft for review; hold CI changes until after the 0.2.0 release freeze.