Add Inkling attention support to vLLM runtime - #2135
Draft
meenchen wants to merge 1 commit into
Draft
Conversation
Signed-off-by: weimingc <17592131+meenchen@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: new feature
Adds ModelOpt attention support for vLLM 0.26's model-specific
InklingAttentionpath:The root cause was that Inkling uses a model-specific module rather than vLLM's regular
Attentionsubclass. It also performs fused Q/K/V preparation and calls a private relative-attention implementation, so the existing ModelOpt discovery and adapter paths could not install attention quantization or sparsity.Usage
A standalone GPU smoke workload is available at
tools/launcher/examples/smoke/inkling_attention.yaml.Testing
Validated with vLLM 0.26.0 on NVIDIA GB300:
INKLING_ATTENTION_SANITY_OK 0.26.0 NVIDIA GB300.Full 66-layer Inkling checkpoint serving and benchmark evaluation have not yet been run; this PR is intentionally a draft.
Before your PR is "Ready for review"
CONTRIBUTING.md: N/AAdditional Information
Branch commit:
9c56d882de1c9f1a2686e3d6d44446d8bf0229e7.