fix(launcher): increase Nemotron 3.5 Lightning QAD parallelism - #2191
Conversation
Signed-off-by: Jennifer Chen <jennifchen@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe QAD launcher example now documents and configures four B200 nodes with TP=1 and CP=4. It also documents the 8K-per-rank context constraint. ChangesQAD topology
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR adjusts the Nemotron 3.5 Lightning QAD launcher configuration to use more GPUs and different parallelism settings; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
==========================================
+ Coverage 78.77% 78.80% +0.03%
==========================================
Files 522 522
Lines 60461 60461
==========================================
+ Hits 47629 47648 +19
+ Misses 12832 12813 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
What does this PR do?
Type of change: Bug fix
Current Nemotron 3.5 Lightning QAD example can OOM, and also TP=2 is not supported for static quantization. Increase GPUs, CP and decrease TP=1
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Make sure you read and follow Contributor guidelines and your commits are signed (
git commit -s -S).Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded
trust_remote_code=True,torch.load(..., weights_only=False),pickle, etc.).CONTRIBUTING.md: ✅ / ❌ / N/AAdditional Information
Summary by CodeRabbit