feat: expose event sanitizers in Node.js [4/6]#374
Draft
willkill07 wants to merge 1 commit into
Draft
Conversation
78c49b4 to
dc468b7
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Will Killian <wkillian@nvidia.com>
dc468b7 to
53da5ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Exposes the mark and scope event sanitizer registries from PRs #371 and #372 through the Node.js binding and plugin context.
Details
PluginContextand TypeScriptEventSanitizeFieldsdeclarations.markto PII configuration typing and defaults.Validation:
just test-node(251 tests), focused event sanitizer tests, 100% JavaScript wrapper coverage, formatting, docstring checks, Clippy, and pre-commit.Where should the reviewer start?
Start with
crates/node/src/api/mod.rs,crates/node/src/callable.rs, andcrates/node/tests/event_sanitizers_tests.mjs.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)