Skip to content

feat: expose event sanitizers in Node.js [4/6]#374

Draft
willkill07 wants to merge 1 commit into
NVIDIA:mainfrom
willkill07:feat/relay-409-node-event-sanitizers
Draft

feat: expose event sanitizers in Node.js [4/6]#374
willkill07 wants to merge 1 commit into
NVIDIA:mainfrom
willkill07:feat/relay-409-node-event-sanitizers

Conversation

@willkill07

Copy link
Copy Markdown
Member

Overview

Exposes the mark and scope event sanitizer registries from PRs #371 and #372 through the Node.js binding and plugin context.

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

  • Adds runtime and scope-local N-API registrations.
  • Extends JavaScript PluginContext and TypeScript EventSanitizeFields declarations.
  • Adds mark to PII configuration typing and defaults.
  • Uses the direct/thread-safe callback paths required by synchronous and async runtimes.
  • Tests conversion, ordering, field removal, invalid callbacks, scope cleanup, plugin cleanup, and PII configuration.
  • Contains no documentation changes; documentation is isolated in a final independent PR.
  • Breaking changes: none.

Validation: just test-node (251 tests), focused event sanitizer tests, 100% JavaScript wrapper coverage, formatting, docstring checks, Clippy, and pre-commit.

Where should the reviewer start?

Start with crates/node/src/api/mod.rs, crates/node/src/callable.rs, and crates/node/tests/event_sanitizers_tests.mjs.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to: RELAY-409

@github-actions github-actions Bot added size:L PR is large Feature a new feature lang:js PR changes/introduces Javascript/Typescript code lang:rust PR changes/introduces Rust code labels Jul 7, 2026
@willkill07 willkill07 added this to the 0.6 milestone Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

@willkill07 willkill07 self-assigned this Jul 7, 2026
@willkill07 willkill07 changed the title feat: expose event sanitizers in Node.js feat: expose event sanitizers in Node.js [4/6] Jul 7, 2026
@willkill07 willkill07 changed the base branch from fix/relay-409-pii-event-redaction to main July 8, 2026 21:36
@github-actions github-actions Bot added size:XL PR is extra large and removed size:L PR is large labels Jul 8, 2026
@willkill07 willkill07 force-pushed the feat/relay-409-node-event-sanitizers branch from 78c49b4 to dc468b7 Compare July 8, 2026 21:40
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 10a4cc0f-12a3-40f2-abbd-7b0f5a647ed5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:L PR is large and removed size:XL PR is extra large labels Jul 8, 2026
Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 force-pushed the feat/relay-409-node-event-sanitizers branch from dc468b7 to 53da5ed Compare July 9, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature a new feature lang:js PR changes/introduces Javascript/Typescript code lang:rust PR changes/introduces Rust code size:L PR is large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant