Skip to content

feat(podman): honor OCI image working directories - #2563

Open
matthewgrossman wants to merge 1 commit into
feat/2526-oci-working-dir/matthewgrossmanfrom
feat/2526-oci-working-dir-podman/matthewgrossman
Open

feat(podman): honor OCI image working directories#2563
matthewgrossman wants to merge 1 commit into
feat/2526-oci-working-dir/matthewgrossmanfrom
feat/2526-oci-working-dir-podman/matthewgrossman

Conversation

@matthewgrossman

Copy link
Copy Markdown
Contributor

Summary

Extend the Docker/shared OCI working-directory support from #2530 to the Podman driver. Podman validates the original immutable image before its workspace volume masks the OCI workdir, then launches the sandbox at the validated path without expanding the image user's filesystem authority.

This PR is conventionally stacked on #2530 and should be reviewed after that Docker/shared base.

Related Issue

Part of #2526

Changes

  • validate the OCI workdir in a minimal temporary probe container created from the same pinned image ID
  • run the probe without the workspace volume, network, secrets, or sandbox token
  • attest the validated image identity through driver-owned metadata before supervisor startup
  • mount Podman persistence at the resolved OCI workdir and reject conflicting driver-config mounts
  • add wait, log collection, cleanup, and failure diagnostics for the probe lifecycle
  • cover Podman OCI identity, supplementary groups, nested volumes, and forged validation metadata
  • update Podman driver, architecture, user, CI, and agent guidance

Testing

  • mise run pre-commit passes
  • cargo test -p openshell-driver-podman -p openshell-driver-docker -p openshell-supervisor-process -p openshell-sandbox passes
  • cargo test -p openshell-server --features test-support passes
  • E2E coverage added/updated for Podman OCI workdir and identity behavior

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture and user documentation updated

@github-actions

Copy link
Copy Markdown

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
@matthewgrossman
matthewgrossman force-pushed the feat/2526-oci-working-dir-podman/matthewgrossman branch from 27deaf6 to a7e1ee7 Compare July 30, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant