Skip to content

fix(ci): preserve KVM access across udev restarts - #2566

Merged
matthewgrossman merged 2 commits into
mainfrom
codex/fix-kvm-udev-reset
Jul 30, 2026
Merged

fix(ci): preserve KVM access across udev restarts#2566
matthewgrossman merged 2 commits into
mainfrom
codex/fix-kvm-udev-reset

Conversation

@matthewgrossman

Copy link
Copy Markdown
Contributor

Summary

Keep VM E2E KVM access intact when package installation restarts systemd-udevd. Configure a persistent udev rule after dependencies and verify that the runner can actually open /dev/kvm before continuing.

Related Issue

Related to the failed Release Tag job: https://github.com/NVIDIA/OpenShell/actions/runs/30553217578/job/90914553277

Changes

  • Configure KVM access after package installation so needrestart cannot immediately undo the setup.
  • Install a persistent udev rule that preserves mode 0666 across subsequent device events.
  • Replace permission-bit checks with an actual open of /dev/kvm.

Testing

  • mise run pre-commit
  • VM E2E test (requires a Linux KVM runner; draft PR CI will exercise it)

Checklist

  • Follows Conventional Commits
  • Commit is signed off for DCO
  • Reviewed related agent skills; no updates required

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@pimlock

pimlock commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/ok to test b1c44ba

@matthewgrossman
matthewgrossman marked this pull request as ready for review July 30, 2026 22:04
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

@pimlock pimlock left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Some references that mention this fix:

I'm assuming that the old version was something that agent came up with and this seems to be a proper way to configure it.

@matthewgrossman
matthewgrossman added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit 596d729 Jul 30, 2026
64 of 67 checks passed
@matthewgrossman
matthewgrossman deleted the codex/fix-kvm-udev-reset branch July 30, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants