Conversation
Add --stream-stdin using the existing interactive exec RPC without a PTY. Preserve separate output streams and enforce the existing 4 MiB cumulative input cap while forwarding input. Require explicit clean stdin EOF and drain the response through its final gRPC status. Cover held-open input, limits, cancellation, trailers, and default finite-input behavior with subprocess and live sandbox regressions. Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 28, 2026 22:20
Treat transport termination and response cancellation as separate test observations. Verify explicit stdin EOF through the shared frame writer and cover cancellation in the pinned Tonic decoder. Signed-off-by: Shiju <shiju@nvidia.com>
Preserve upstream removal of obsolete architecture documents and retain streaming guidance in the published sandbox documentation. Signed-off-by: Shiju <shiju@nvidia.com>
johntmyers
added
gator:in-review
johntmyers
reviewed
Sep 29, 2026
johntmyers
left a comment
johntmyers
left a comment
Collaborator
There was a problem hiding this comment.
gator-agent
PR Review Status
This concentrated CLI feature is project-valid through linked issue #3802. The initial full-diff review found no blocking defects, and the user-facing command documentation and public CLI skill are updated.
Blocking findings:
- No blocking findings remain
Carried findings:
- None
Non-blocking suggestions:
- None
Gator metadata
- Validation: Linked issue #3802 defines the user path, failure semantics, input limit, and acceptance criteria; duplicate search found no overlapping work.
- Docs: Fern sandbox documentation and the public CLI skill are updated for
--stream-stdin. - Checks: Existing current-head branch, Helm, Trivy, and DCO gates are green; E2E dispatch is still being evaluated after label application.
- E2E:
test:e2eapplied because sandbox execution behavior changed; E2E Label Help is running. - Head SHA:
1ca240f5d879b721d00782393e8f6af77d52ebc7 - Base SHA:
33a8eac196a21aff3125dea46462a4591bcb5d0b - Merge base SHA:
33a8eac196a21aff3125dea46462a4591bcb5d0b - Patch ID:
20ec711c4a8a2d7516b076ee7739e1879626e64a - Gator payload:
9 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:in-review
|
Label |
johntmyers
added
gator:watch-pipeline
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
sandbox exec --stream-stdinso a client can exchange requests and responses with one remote process before closing stdin. The mode runs without a TTY and keeps stdout and stderr separate.Related Issue
Closes #3802
Changes
Testing
mise run pre-commitpassesChecklist