Conversation
Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 29, 2026 12:35
Preserve upstream architecture documentation removal while retaining the published stdin overload contract. Signed-off-by: Shiju <shiju@nvidia.com>
Keep the pending-input limit beside the RPC lifecycle contract so the streaming CLI documentation can merge independently. Signed-off-by: Shiju <shiju@nvidia.com>
|
Label |
johntmyers
reviewed
Sep 29, 2026
johntmyers
left a comment
Collaborator
There was a problem hiding this comment.
gator-agent
PR Review Status
The initial code-only review found no blocking findings. The supervisor-process change is project-valid as a localized resource-bound and cancellation fix, its user-visible overload behavior is documented, and the required E2E workflow is queued for this head.
Blocking findings:
- No blocking findings remain
Carried findings:
- None
Non-blocking suggestions:
- None
Gator metadata
- Validation: Localized supervisor correctness fix with handler-level regression coverage
- Docs: Fern documentation updated in
docs/how-it-works/sandboxes/overview.mdx - Checks: Current-head baseline checks completed; required E2E is queued
- E2E:
test:e2eapplied and Branch E2E Checks run36630140527rerun queued - Head SHA:
2595b40f6f060437ccb5b29c1145b499e9d80bcd - Base SHA:
33a8eac196a21aff3125dea46462a4591bcb5d0b - Merge base SHA:
33a8eac196a21aff3125dea46462a4591bcb5d0b - Patch ID:
a296c71d0634a50b6252e3a70c1dd620c426e2c6 - Gator payload:
9 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:watch-pipeline
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound pending stdin to 4 MiB per ordinary SSH exec channel, including the active write, and release stalled input writers on channel close or disconnect. Overflow reports exit code 74 and requests termination of the affected exec while keeping the SSH callback responsive to other channel traffic.
Related Issue
No issue required: this corrects an unbounded queue and detached input writer in the existing exec path.
Changes
Testing
mise run pre-commitpassesChecklist