fix(analyzer): stabilize TM1 window identity - #578
chrisknvidia wants to merge 27 commits into
Conversation
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
rng1995
left a comment
There was a problem hiding this comment.
Reviewed exact draft head d856d88c289c5ef3389060ef69651c9981aae38f. I found no additional blocker in the focused TM1 identity range (f2ae98f..d856d88): 220 focused tests and 392 current-main merged-tree regressions pass, and lint/format/diff checks are clean.
I am requesting changes because the current combined tree still contains both confirmed dependency blockers from #576 and #577. On this exact head, a three-row ledger cap drops the second distinct fatal fact, and shell=enabled still evades TM1 when a later argument expression is effectful. The PR is also still draft and its own review contract requires #576/#577 to land, a rebase onto current main, fresh CI, and current-head review.
Please propagate the dependency fixes and rebase. If the focused range remains semantically unchanged and CI stays green, I found it otherwise suitable for approval.
…e-475-shell-truthiness-core Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
…rsive-fail-closed-reporting Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com> # Conflicts: # src/skillspector/nodes/analyzers/static_patterns_tool_misuse.py # src/skillspector/nodes/analyzers/static_runner.py
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com> # Conflicts: # src/skillspector/nodes/analyzers/static_patterns_tool_misuse.py # src/skillspector/nodes/analyzers/static_python_shell_truthiness.py # tests/nodes/analyzers/test_tool_misuse_python_ast.py
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Summary
Review context
This is the focused TM1 window/identity follow-up split from #497.
Open stacked dependencies: #576 at
fb86cf753c8e4a15cbaca12f39f106bc4a6cf8dfand #577 atc3b0ff945013f2cc0eeaeb66515ba099d184478a. Neither dependency has merged. This branch incorporates those exact heads, plus currentorigin/mainatd162d9b343e559be13df8ebba093df3bc9d58c90, through DCO-signed-off merge commits without rewriting the published branch.The original focused TM1 review range remains:
That original range is 5 files (+3,264/-192). The current combined head also contains the dependency fixes and conflict resolutions needed to integrate main's paragraph-aware prose matching, plus DCO-signed-off follow-up
1404c29671c35e48e13f0da2c602d6cf16d4e5afso normalized and declared-marker projections retain the true source prefix under low caps.Validation at current head
partial/output_limit, restored source coordinates, and exposed no private_tm1_evidenceNo live LLM/provider call was run or required: this change is confined to the static analyzer path. The PR remains stacked on open #576/#577 and still requires current-head reviewer approval before merge.