Repository navigation
Conversation
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Signed-off-by: Evgeny <etsykunov@nvidia.com>
for more information, see https://pre-commit.ci
| native.internal = True | ||
| q = NVFP4QDQQuantizer(native) | ||
| q.amax_reduction_group = dist.group.WORLD | ||
| q.with_amax_reduction = True |
There was a problem hiding this comment.
can it support NVFP4 with per token second scale instead of global amax?
| * ``nvfp4_qdq_weight_fwd_bf16_bwd_factory`` models ``X[BF16] x W[NVFP4]`` | ||
| forward and uses BF16 backward. Backward consumes the original inputs and | ||
| the decoded forward QDQ weights. | ||
| * ``mxfp8_nvfp4_qdq_fwd_mxfp8_bwd_factory`` models ``X[MXFP8] x W[NVFP4]`` |
There was a problem hiding this comment.
X[MXFP8_QDQ] x W[NVFP4_QDQ] ?
the same comment is applied to all QDQ types used in the code and description
also in function name may be it is better to explicitly name it as
mxfp8_qdq_nvfp4_qdq_fwd_mxfp8_bwd_factory
I would suggest to add QDQ to all names of mxfp8 and nvfp4 when qdq is applied
rybakov
left a comment
There was a problem hiding this comment.
looks good, with comment about QDQ naming in the description and function names
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Signed-off-by: Evgeny <etsykunov@nvidia.com>
|
/te-ci pytorch |
[High impact] The PR appears safe to merge; the older-CUDA test failure is fixed and no new blocking issue was found. SummaryAdds experimental MXFP8 and NVFP4 QDQ quantizers that store decoded operands for high-precision GEMMs.
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart LR
Input[Original operand] --> Choice{QDQ backend}
Choice -->|Supported| Fused[Fused quantize and decode]
Choice -->|Reference| Native[Native quantize then decode]
Fused --> HP[High-precision storage]
Native --> HP
HP --> Forward[High-precision forward GEMM]
HP --> Backward[Optional backward quantizer]
Reviews (3) · Last reviewed commit: "Allow CustomRecipe without FP8 hardware ..." · Reviewed by Greptile |
Signed-off-by: Evgeny <etsykunov@nvidia.com>
|
/te-ci pytorch |
Signed-off-by: Evgeny <etsykunov@nvidia.com>
|
/te-ci pytorch |
Description
Adds experimental MXFP8 and NVFP4 quantize–dequantize (QDQ) quantizers, similar to radixark/miles#2864.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: