Repository navigation
Conversation
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
kainzhong
force-pushed
the
more_cutedsl_mxfp8_specialized
branch
from
October 12, 2026 18:45
4b9ef6b to
ef9877d
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
kainzhong
marked this pull request as ready for review
October 12, 2026 20:24
Contributor
[Medium impact] The changes appear safe to merge; the previous plain-cast mismatch is fixed and no new actionable issue was found. SummaryAdds specialized CuTeDSL MXFP8 kernels and splits the existing implementation into shared dispatch code and separate kernel files.
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[MXFP8 quantization request] --> B[Shared configuration and dispatch]
B --> C{Specialized kernel supports this call?}
C -->|Yes| D[Rowwise or bidimensional kernel]
C -->|No| E[General shared-memory kernel]
D --> F[FP8 values and block scales]
E --> F
Reviews (11) · Last reviewed commit: "nit" · Reviewed by Greptile |
kainzhong
force-pushed
the
more_cutedsl_mxfp8_specialized
branch
from
October 12, 2026 21:05
113f73a to
cae94f5
Compare
kainzhong
force-pushed
the
more_cutedsl_mxfp8_specialized
branch
from
October 12, 2026 21:11
0a9824e to
f67b1e5
Compare
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
kainzhong
force-pushed
the
more_cutedsl_mxfp8_specialized
branch
from
October 15, 2026 20:29
ba1f62d to
5c3465a
Compare
Signed-off-by: Kaining Zhong <kainingz@nvidia.com>
kainzhong
force-pushed
the
more_cutedsl_mxfp8_specialized
branch
from
October 15, 2026 23:58
3a80e08 to
dba8dbf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add specialized MXFP8 CuTeDSL quantization kernels ported from #3459
And also some refactoring of the existing kernel -- so
quantize_mxfp8.pybecomesquantize_mxfp8_common.py: kernel config, signature, dispatching and registerationquantize_mxfp8_g2s_general.py: the same general MXFP8 kernel that handles all casesquantize_mxfp8_g2r_rowwise_1lane.py: the same old rowwise specialized kernelquantize_mxfp8_g2s_bidim.py: the same old bidim specialized kernelg2sandg2rmean the kernel uses SMEM / RMEM to quantizeNote: CuTeDSL cannot exactly mirror CUDA's implementation due to a bug in cutlass: NVIDIA/cutlass#3726
Type of change
Changes
Difference with the CUDA path:
Benchmark result: (BF16 only, since the new G2R kernels only support BF16, and activation is gelu)
https://claude.ai/artifact/SzJ4HBGpo5KRS2VzSpbim5?sk=g7SsHtfq1MQxEzpL4z-Rpg
Non-Swizzled scale
Swizzled scale
Checklist: