Move release CI tools tests to nightly#2279
Conversation
|
/ok to test d51e0dd |
This comment has been minimized.
This comment has been minimized.
|
If you apply this commit d29bc34 you can test the nightly CI in this PR to observe the effect, once it's green we can revert/merge. |
|
/ok to test 24780b0 |
@lijinf2, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
|
/ok to test b712ef4 |
|
/ok to test b712ef4 |
@lijinf2, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
|
/ok to test df299a2 |
|
/ok to test 58fd95e |
|
|
||
| - name: Run CI tools unit tests | ||
| run: | | ||
| python -m pip install pytest |
There was a problem hiding this comment.
Q: have you verified that this works? I assume we need to call setup-python first?
There was a problem hiding this comment.
Yes. I verified it on CI. It shows "Nightly: CI tools for release" job passed.
It looks ubuntu-latest comes with python pre-installed, and setup-python isn't strictly required here. We can add it to keep things consistent if there's a chance. Or let me know if you think we should do it now as a follow-up.
Thanks! Cherry-picking d29bc34 worked — nightly CI and test-ci-tools-for-release both passed as shown here. It looks manual trigger via Github Separate issue: numba 0.66.0 (just released today July 1) started breaking nightly numba-cuda on Windows. This is unrelated to this PR (we only move ci/tools/tests to nightly). Also, Nightly had already passed with the cherry-pick trigger (before numba 0.66.0 release). Could we merge this PR without waiting on the numba-cuda pin/fix? |
|
Thanks, Jinfeng!
It's OK. We'll fix it in NVIDIA/numba-cuda#905. |
|
Admin-merging. |
|
Description
closes #2174
Move
ci/tools/tests/out of the pre-merge test path and into nightly CI so release-time helpers (notablycheck_release_notes.py, used byrelease.yml) are exercised regularly without adding meta-tests to every PR.Checklist