Skip to content

Unconditionally stop early_cpufj if launched - #1846

Open
vitor1001 wants to merge 1 commit into
NVIDIA:mainfrom
vitor1001:mip_concurrency_fixes
Open

Unconditionally stop early_cpufj if launched#1846
vitor1001 wants to merge 1 commit into
NVIDIA:mainfrom
vitor1001:mip_concurrency_fixes

Conversation

@vitor1001

Copy link
Copy Markdown
Contributor

If early_cpufj was started, it should be stopped and joined regardless of whether presolve finished with a result or failed/timed out, matching the behavior of early_structural.

Full disclosure: done with the help of Gemini AI.

Description

Issue

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

If early_cpufj was started, it should be stopped and joined regardless of
whether presolve finished with a result or failed/timed out, matching the
behavior of early_structural.
@vitor1001
vitor1001 requested a review from a team as a code owner September 3, 2026 13:02
@copy-pr-bot

copy-pr-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 615b6688-5d20-46e7-b14a-5240ae0d81b8

📥 Commits

Reviewing files that changed from the base of the PR and between 2909393 and a00892d.

📒 Files selected for processing (1)
  • cpp/src/mip_heuristics/solve.cu

Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Early CPUFJ cleanup

Layer / File(s) Summary
Early CPUFJ lifecycle cleanup
cpp/src/mip_heuristics/solve.cu
The solve path now stops and releases early CPUFJ whenever it was created, including runs without completed presolve.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a0089

Launched early CPUFJ work is now stopped and joined regardless of presolve outcome, preventing lifecycle cleanup from being skipped. No actionable merge-readiness risk remains.

Suggested reviewers: aliceb-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains that launched early_cpufj processes must be stopped and joined in all presolve outcomes. This matches the changeset and PR objective.
Title check ✅ Passed The title clearly and concisely summarizes the main change: always stop early_cpufj after it is launched.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant