Repository navigation
chore(internals): drop unused string assertion in examples service - #575
Merged
Merged
Conversation
Removes the unnecessary string assertion from ExamplesService.list. The declared return type already accepts the expression, and the assertion had no runtime effect. Repository suppressions for @typescript-eslint/no-unnecessary-type-assertion go from 194 to 193. Co-authored-by: Cory Rylan <coryrylan@users.noreply.github.com> Signed-off-by: Cursor Agent <cursoragent@cursor.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
 |
coryrylan
approved these changes
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
Lint mode B. Selector rationale:
Measurement
@typescript-eslint/no-unnecessary-type-assertionsuppressions: 194 → 193.The finding in
projects/internals/tools/src/examples/service.tswasreturn results as stringinExamplesService.list. ESLint reported that the assertion is unnecessary because the declared return type already accepts the expression. Warm and cold type-aware lint (withprojects/internals/tools/distandprojects/internals/metadata/distmoved aside) both reported that same finding before the edit and zero findings in the file after it.Public API
No public API changed. The
ExamplesService.listsignature is unchanged, and the removed assertion had no runtime effect.Left alone
The other assertions in this file (
as Example[]) still change the type, so they stay. Other suppressed files were not edited.pnpm run testin this package still failssetup-agent.test.tswithEACCESonmkdir '/project/.agents/skills/elements'when Vitest does not isolate modules. That failure is pre-existing on this VM and is outside this change. Package CI usestest:coverage, which passed (29 files, 745 tests), includingsrc/examples/service.test.ts(16 tests).Validation
projects/internals/toolshas noDEVELOPMENT.md. Its scripts arelint,test,test:coverage, andtest:watch.pnpm run lint: passpnpm run test: fail, pre-existingsetup-agent.test.tsEACCES (11 tests). The examples service tests passed.test:types,test:axe,test:ssr,test:lighthouse,test:visual: not definedpnpm run test:coverage: pass (745 tests)CI=true pnpm run ci: pass (6 ran, 191 skipped)git diff --check: clean