Conversation
down_read_trylock() and down_write_trylock() return nonzero on successful acquisition and zero on failure. Negate both checks so the conditional rwlock wrappers return NV_ERR_TIMEOUT_RETRY only when acquisition fails, and NV_OK when it succeeds. Signed-off-by: Bryant Ly <bly@coreweave.com>
|
|
Member
|
Thanks for reporting this. It looks like this was already fixed internally and the fix will be in a future release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux documents down_read_trylock() and down_write_trylock() as returning 1 on successful acquisition and 0 on contention.
Negate both checks so the conditional rwlock wrappers return
NV_ERR_TIMEOUT_RETRYonly when acquisition fails, andNV_OKwhen it succeeds.