Preserve libdispatch bulk child sender value category - #2205
Open
fallintoplace wants to merge 2 commits into
Open
Preserve libdispatch bulk child sender value category#2205fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
ericniebler
approved these changes
Aug 16, 2026
Collaborator
|
/ok to test 0e21d95 |
Collaborator
|
/ok to test b69ba18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
bulk_op_statecomputesinner_op_statefromCvSender, but usedstd::move(sndr)when connecting it. For an lvalue bulk sender, that turned a validSender&connection into an rvalue connection.Test
ctest --test-dir build --output-on-failure -j 8