Skip to content

Fix iterate subscribe exception specification - #2206

Open
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/iterate-subscribe-noexcept
Open

Fix iterate subscribe exception specification#2206
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/iterate-subscribe-noexcept

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

What

  • Make iterate report when range access or operation-state construction can throw during subscribe.
  • Add a regression for a range whose begin() throws.

Why

iterate_t::subscribe() derives its exception specification from an internal helper, but that helper was unconditionally noexcept even though it calls ranges::begin() and ranges::end(). A throwing range could therefore terminate instead of propagating the subscription exception.

Test

  • ctest --test-dir build --output-on-failure -j 8
  • All 948 tests passed.

@copy-pr-bot

copy-pr-bot Bot commented Aug 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant