Skip to content

Fix read_with_default connect noexcept - #2208

Open
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/read-with-default-connect-noexcept
Open

Fix read_with_default connect noexcept#2208
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/read-with-default-connect-noexcept

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

What changed

  • Make read_with_default member connect() derive its exception specification from constructing the returned operation state.
  • Add a regression for a default value whose move throws during connect().

Why

The operation state already accounts for a potentially throwing default move, but connect() only considered moving the receiver.

Testing

  • build/test/exec/test.exec (3345 assertions passed)
  • ctest --test-dir build --output-on-failure -j 8 (948 passed)

@copy-pr-bot

copy-pr-bot Bot commented Aug 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant