Repository navigation
Conversation
Tchips46
reviewed
Oct 30, 2026
Tchips46
left a comment
Member
There was a problem hiding this comment.
Review: simplify interfaces (02aac04)
Line numbers are at this PR's head.
Must fix
1. The migration switches new users to "full" on their second load (packages/ui/src/workbench/setup/setup-workbench.ts:121-134)
- When the layout came from a save, no scope holds
layout.preset, andsavedNames.length > 0, it writes'full'. - Nothing ever writes
simplefor a new user. Their first layout change is saved after 500 ms (_set→_persist), so on the next loadfirstRunis false, a saved name exists, and the migration takes them for an existing user. From then on every new project and every Reset layout shows all panels, againstlayout.mdx:43. - Not caught because the migration has no test, and e2e
resetLayoutalways writes'full'. - Fix: whenever no scope holds a preset, write one:
'full'if!layout.firstRun && savedNames.length, otherwise'simple'.
Should fix
2. The INTERNAL and TIMEOUT hints replace git's own messages with wrong ones (packages/ui/src/workbench/notification/describe-error.ts:23-28, reached from plugins/git/src/index.ts:44)
- Every failed git command throws
RpcError('INTERNAL', <git stderr>)(server-core/src/git/git-service.ts:445). A rejected push now says "Something went wrong in the editor server", with git's reason hidden behind Show details. - A stuck push throws
RpcError('TIMEOUT', "git push got no answer from the remote… run it once in a terminal")(git-service.ts:434). The toast now says "The editor server took too long to answer", which is false, and the fix is hidden. - Fix: give the INTERNAL hint only when the message is the router's generic
'Internal error'(packages/rpc/src/router/router-entries.ts:26), and drop TIMEOUT fromHINTS(the client's own timeout message is already plain).
3. usePreset writes the account scope, which a machine value outranks (setup-workbench.ts:107-118)
- Example: Default layout set to "All panels" under This machine, then View › Layouts › Simple layout. The reset is simple, but the next Reset layout is full again.
- Fix: write to
settings.inspect(CoreSettings.layoutPreset).effectiveScopewhen it is account or machine.
4. The widget description field is missing from the plugin docs (docs/docs/plugins/manifest.mdx:84-96)
- The table gained
essentialbut notdescription, which four manifests already use. Add one row.
Nice to have
- Tab tooltips (
packages/ui/src/workbench/parts/TopBar.svelte:74, 92): a screen with no description gets a tooltip that repeats its own label, and the visually hidden description span inside the tablist is read twice in browse mode. Wrap inTooltiponly when there is a description, and give the spanhidden(aria-describedbystill reads it). - Lean:
errorCodeOf(describe-error.ts:32) repeatsapps/editor/src/lib/editor/error-description.ts:17(errorCode),packages/settings/src/account-sync/account-sync-store.ts:27and thecodeOfhelpers in the packages and settings-ui plugins. Keep one. - Docs (
docs/docs/getting-started/create-your-first-project.mdx:41-43): the new paragraph splits the bullet list, andeditor-overview.pngstill shows the full layout.
Exeloo
force-pushed
the
refactor/simplify-interfaces
branch
2 times, most recently
from
November 1, 2026 14:27
5bc886d to
7b1a1fc
Compare
Exeloo
force-pushed
the
refactor/simplify-interfaces
branch
from
November 1, 2026 14:52
7b1a1fc to
1e3b76c
Compare
- the default layout is written once for new users too, so a saved layout no longer turns them into full-layout users; users with other recent projects keep every panel - choosing a layout writes the scope that holds the default - git's own messages are kept on internal errors and timeouts - a screen tab gets a tooltip only when it has a description - docs: widget description, layout paragraph
Exeloo
force-pushed
the
refactor/simplify-interfaces
branch
from
November 1, 2026 15:39
1e3b76c to
8a1c6c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplify interfaces by reducing the amont of text, of sub buttons, and add button before more details.
How do you test this PR?