Skip to content

feat(dpav3311) iam keycloak client - #89

Merged
nikan-negaresh-informed merged 3 commits into
developfrom
feature/DPAV-3311-iam-keycloak-client
Oct 18, 2026
Merged

nikan-negaresh-informed merged 3 commits into
developfrom
feature/DPAV-3311-iam-keycloak-client

Conversation

@AdamBartosikInfo

Copy link
Copy Markdown

Sensitive Credential Checks

  • As the author of these changes, I have checked for any sensitive credentials prior to this review being requested.
  • As a reviewer of these changes, I have checked for any sensitive credentials prior to approving this merge.

Motivation and Context

Description

  • Describe your changes in detail

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • It contains only changes required by issue (does not contain other PR)
  • Includes link to an issue (if apply)
  • I have added tests to cover my changes.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

OSS Checks Passed

All tracked OSS checks passed in this run.

Total Files Passed Failed Score
13 13 0 100%

Results from commit 65fff65, view the full job summary for detailed results.

♻️ This comment has been updated with latest results.

@nikan-negaresh-informed nikan-negaresh-informed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one point ,

can we confirm that this IAM_INTEGRATION_SERVICE should not require existing Federator_CONSUMER and Federator Producer roles?

what you are building is not a federator so it should inherit those.

If you confirm that, we should be able to approve this

@AdamBartosikInfo

Copy link
Copy Markdown
Author

@nikan-negaresh-informed Confirmed, IAM_INTEGRATION_SERVICE is not a federator and does not need the federator scopes. I removed them: it now gets only the roles scope (it only calls the Keycloak admin API, which reads realm-management from the token). Other clients are unchanged.

@sonarqubecloud

Copy link
Copy Markdown

@nikan-negaresh-informed
nikan-negaresh-informed enabled auto-merge (squash) October 18, 2026 17:32
@nikan-negaresh-informed
nikan-negaresh-informed merged commit 36559e5 into develop Oct 18, 2026
10 checks passed
@nikan-negaresh-informed
nikan-negaresh-informed deleted the feature/DPAV-3311-iam-keycloak-client branch October 18, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants