fix(ns-api): improve ns.ha arguments handling - #1866
Merged
Merged
Conversation
gsanchietti
marked this pull request as draft
August 6, 2026 07:36
Sanitize JSON payloads sent to the HA peer and validate all HA API parameters before use. Also handle validation errors in the CLI dispatcher instead of crashing. Assisted-by: Claude Code:claude-opus-5[1m]
m-dilorenzi
approved these changes
Aug 6, 2026
Contributor
|
I tested in my environment and I was able to successfully create a working HA cluster from scratch. |
Tbaile
approved these changes
Aug 10, 2026
Member
Author
|
Testing image: 8.8.0-dev.358.20260824080545.0809270 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanitize JSON payloads sent to the HA peer and validate all HA API parameters before use. Also handle validation errors in the CLI dispatcher instead of crashing.