feat(testutil): port verifypr PR template verification - #691
Open
varex83agent wants to merge 1 commit into
Open
Conversation
Closes #160. Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #160.
Ports Charon's
testutil/verifyprtopluto-testutil::verifypr: averify_title/verify_bodypair that checks a PR'spackage[/subpackage]: subjecttitle and itscategory:/ticket:/feature_flag:body tags, plus averifyprbinary that reads the PR JSON fromGITHUB_PR.feature_flag:values resolve against an injectedpluto_featureset::FeatureSet(min statusalpha) since Pluto has no global feature state. Both Go unit test tables (TestTitle,TestBody) are ported astest-casetables; the Go cases that enable ad-hocfoo/barflags use the realmock_alpha/quicfeatures instead.Co-Authored-By: Bohdan Ohorodnii 35969035+varex83@users.noreply.github.com