feat(auth): support async MapKit token providers#84
Open
iloveitaly wants to merge 2 commits into
Open
Conversation
- Update `loader` to support `authorizationCallback` requests occurring after the initial map load. - Ensure the `Map` component keeps the loader's token provider synced with current props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MapKit JS can request a new JWT throughout a session, but mapkit-react only accepted a static string, so short-lived server-minted tokens and mid-session refresh were awkward or unsupported.
Description
tokentostring | (() => string | Promise<string>)and resolve it in the loader’sauthorizationCallbackwhenever MapKit asks for credentials.tokenprop via a ref (for re-auth after init without re-creating the map).authorizationCallbacksupported insupport.md, and add a Storybook example using an inline async provider.Test
tokenstill loads maps; async provider story returns a JWT and loads MapKit.Links
Fixes #3