Remove PyTorch dependency by using nvidia-smi for GPU check#2
Open
google-labs-jules[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Importing PyTorch (
torch) solely to check for GPU availability and retrieve the device name in the UI introduces a massive, unnecessary dependency to the production environment. This heavily bloats the installation payload, slows down setup times, and increases resource consumption on standard installations.By replacing this check with a native, lightweight alternative, we can completely remove PyTorch from the core production requirements while maintaining the exact same functionality.
What
Lightweight GPU Detection (
cognios/src/ui.py):torch.cuda.is_available()) with a lightweightsubprocesscall tonvidia-smi.torchlibrary to be imported.Dependency Cleanup (
cognios/requirements.txt):torchfrom the production dependencies to drastically reduce the package size and installation overhead.CI/CD & Test Suite Resilience (
test_all.py):test_focus_osto gracefully skip execution usingpytest.importorskip("torch")when PyTorch is not present. This ensures that the test suite passes successfully on standard installations without causing build failures.