Skip to content

[GUI] Seal helper rows when a turn ends so none stay working (#4218) - #4360

Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
Niko1221:mainfrom
xvcezrqpbxtpzblrt:fix/4218-lifecycle
Closed

xvcezrqpbxtpzblrt wants to merge 1 commit into
Niko1221:mainfrom
xvcezrqpbxtpzblrt:fix/4218-lifecycle

Conversation

@xvcezrqpbxtpzblrt

@xvcezrqpbxtpzblrt xvcezrqpbxtpzblrt commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Problem

A helper (subagent) row could stay working after its run ended. The page has no other source for the row, so it kept showing a helper that was no longer running, with a duration that kept growing. Reopening the chat showed the same ghost row.

Fix

  • inishTurn now seals every helper of the run that has not finished: the row is marked interrupted before its stream closes and before the page is told the turn ended.
  • ChildProjector.finished now counts interrupted as final, so a sealed row stops being "live" and its duration stops growing.
  • markStopped() lets a stop the person asked for read "stopped, can continue" instead of "cancelled".

Validation

  • node --test tests/agent-children.test.mjs — 6 pass, 0 fail (includes a new test: a sealed row reads interrupted, is final, and sealing twice changes nothing).
  • Not run: the real Harness end-to-end (needs a running agent), and the page (no browser run). The row frame path is covered by the projector test only.

Scope

This is the seal half of #4218. Kept apart from the row store and the subagent panel so it can be reviewed on its own.

@github-actions github-actions Bot added the needs-format Title or template does not follow CONTRIBUTING.md yet label Oct 27, 2026
@github-actions

Copy link
Copy Markdown

Thanks for the pull request. To keep the tracker readable, every item needs an area prefix in the title and the parts of the pull request template filled in. This one is missing:

  • Fill in "Validation": the exact commands, the revision and environment tested, what you saw. Keep Passed, Failed and Not run apart.

Edit the pull request (title and description) and this note goes away on its own. If it is still missing parts in 5 days it will be closed, which is not a rejection: fix it and comment /reopen.

Details: CONTRIBUTING.md

@xvcezrqpbxtpzblrt xvcezrqpbxtpzblrt changed the title [GUI] Keep subagent rows in the host and repair old ghost durations (#4218) [GUI] Seal helper rows when a turn ends so none stay working (#4218) Oct 28, 2026
@xvcezrqpbxtpzblrt

Copy link
Copy Markdown
Contributor Author

Superseded by #4606, which carries this change with the rest of the 0.2.7 branch. Closing so the review has one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-format Title or template does not follow CONTRIBUTING.md yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant