Repository navigation
[GUI] Seal helper rows when a turn ends so none stay working (#4218) - #4360
Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
xvcezrqpbxtpzblrt wants to merge 1 commit into
Conversation
|
Thanks for the pull request. To keep the tracker readable, every item needs an area prefix in the title and the parts of the pull request template filled in. This one is missing:
Edit the pull request (title and description) and this note goes away on its own. If it is still missing parts in 5 days it will be closed, which is not a rejection: fix it and comment Details: CONTRIBUTING.md |
xvcezrqpbxtpzblrt
force-pushed
the
fix/4218-lifecycle
branch
from
October 28, 2026 09:11
a7aadc2 to
5e8a4cc
Compare
Contributor
Author
|
Superseded by #4606, which carries this change with the rest of the 0.2.7 branch. Closing so the review has one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A helper (subagent) row could stay working after its run ended. The page has no other source for the row, so it kept showing a helper that was no longer running, with a duration that kept growing. Reopening the chat showed the same ghost row.
Fix
interruptedbefore its stream closes and before the page is told the turn ended.ChildProjector.finishednow countsinterruptedas final, so a sealed row stops being "live" and its duration stops growing.markStopped()lets a stop the person asked for read "stopped, can continue" instead of "cancelled".Validation
node --test tests/agent-children.test.mjs— 6 pass, 0 fail (includes a new test: a sealed row readsinterrupted, is final, and sealing twice changes nothing).Scope
This is the seal half of #4218. Kept apart from the row store and the subagent panel so it can be reviewed on its own.