Repository navigation
[Other] Stop is only stopped when the run's folder is really gone - #4442
Open
xvcezrqpbxtpzblrt wants to merge 1 commit into
Open
xvcezrqpbxtpzblrt wants to merge 1 commit into
xvcezrqpbxtpzblrt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Stopping a Time-skip run reported success even when the run's folder was still there.
existsSyncreturns false on a permission error, so "could not be deleted" read as "deleted": the copies of the person's files stayed on disk while the interface said the run had stopped.Result
ENOENTcounts as gone. If the folder is still there after eight seconds,stop()raises, and the route answers with the error instead of a cheerful "stopped".Validation
node --test tests/timeskip-real.test.mjs→ 7 pass, 0 fail, three runs in a row (Windows). The stop case went from failing after 7.9 s to passing in about 0.9 s.Limits
STRATA_HARNESS_DIRis not set; the pure logic and the code path are what the test covers here.