Repository navigation
[GUI] Open the window maximized the first time, and where it was left after that - #4452
Closed
xvcezrqpbxtpzblrt wants to merge 2 commits into
Closed
xvcezrqpbxtpzblrt wants to merge 2 commits into
xvcezrqpbxtpzblrt wants to merge 2 commits into
Conversation
Contributor
Author
|
Superseded by #4606, which carries this change with the rest of the 0.2.7 branch. Closing so the review has one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The window was created at a fixed 1440x920 in the top-left corner and never remembered being maximized. On a 2560x1440 screen that is 38% of the width: every start meant maximizing by hand, and the conversation sat in a corner with the rest of the screen empty.
Result
0.2.0and failed on every run since the version moved to 0.2.7. It now asks for the crate's own version, so the next bump does not break it again.Validation
cargo test --release→ 26 pass, 0 fail, including the newthe_window_reopens_where_it_was_left_and_maximized_on_the_first_run(first run, left un-maximized, an unusable size and place, a damaged file).IsZoomed = trueand a 2576x1408 outer rect;%LOCALAPPDATA%\Strata\window.jsonreads{"maximized": true, ...}.Note
Based on #4438 (the window is shown after the first paint); that one should merge first. The crash-test line is a test-only fix in the same crate, found while running the suite.