Repository navigation
[GUI] Reserve the preview column only when there is something in it - #4453
Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
xvcezrqpbxtpzblrt wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #4606, which carries this change with the rest of the 0.2.7 branch. Closing so the review has one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A preview column could stay reserved with nothing in it. The split's width came from
selectedPreviewalone, while the panel renders nothing when that id matches no artifact, run or plan (an artifact removed from the session, a plan that was rejected, a Time-skip run whose files are gone). The result: a blank 627px column on the right, and the conversation squeezed into the remaining 545px.Measured in the installed app (1440x920 window, the chat from the screenshot):
.chatsplithadgrid-template-columns: minmax(0,1fr) 627pxanddata-preview="true",elementFromPoint(1100, 400)returned the split itself (nothing painted there), and.chat__innerwas 535px wide.Result
Validation
data-previewis absent,splitStyleis null,.chat__inneris 920px wide, centered (681px each side), and the assistant paragraph sits at its 56ch measure inside it.npm run typecheck→ clean;node --test tests/ui4-fixes.test.mjs tests/card-labels.test.mjs tests/context-ui.test.mjs→ 15 pass, 0 fail.EPERMcases), 108 skipped.Limits