Skip to content

[GUI] The installer speaks the nine languages of the app - #4456

Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
Niko1221:mainfrom
xvcezrqpbxtpzblrt:gui/installer-languages-027
Closed

xvcezrqpbxtpzblrt wants to merge 1 commit into
Niko1221:mainfrom
xvcezrqpbxtpzblrt:gui/installer-languages-027

Conversation

@xvcezrqpbxtpzblrt

@xvcezrqpbxtpzblrt xvcezrqpbxtpzblrt commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The app speaks nine languages; its installer spoke one. bundle.windows.nsis.languages held ["English"], the template's own copy (welcome, finish, folder page, uninstall data page) was hardcoded English, and the welcome sidebar picture had State of the art. At home. baked into the bitmap. On a Chinese Windows 11 the installer opened in English.

Result

  • The installer carries the same nine languages as the app: English, Simplified Chinese, Japanese, German, Spanish, Russian, Brazilian Portuguese, Korean and French. NSIS picks the language of the person's Windows; English stays first and is the fallback.
  • Strata's own words are language strings now: welcome title and body, finish title, body and button, both page headers, the folder page text, and the whole "remove your Strata data too" page (title, note, checkbox and the list of folders). The folder paths are the same in every language, so they stay in the page and only the words around them are translated.
  • The sidebar picture keeps the logo and the gradient but no words, so nothing in it can be the wrong language. The header picture was already the logo alone.

Validation

  • The build generated all nine <Language>.nsh files and nine MUI_LANGUAGE lines (English, SimpChinese, Japanese, German, Spanish, Russian, PortugueseBR, Korean, French).
  • Run on Windows 11 with a Chinese system language, screen captured page by page:
    • welcome: title Strata 安装, "顶尖技术,就在家里。", Chinese body, buttons 下一步(N) / 取消(C), no English tagline in the picture;
    • reinstall page: Strata 0.2.7 已经安装了。选择您要执行的操作,然后单击下一步继续。 with 添加/重新安装 and 卸载 Strata;
    • folder page: header 选择 Strata 的安装位置, "C 盘空间不足时,可以换一个磁盘。", and the custom top text in Chinese; no unresolved language reference anywhere.
  • Installer builds and installs: 105.37 MiB, silent install and start verified.

Limits

  • Only Chinese was inspected on screen; the other eight languages are the same table, but they were not run.
  • The installer follows the Windows display language, not the app's own language setting: the app is not installed yet when the installer runs.
  • The sidebar picture lost its English tagline for every language; a per-language picture would need nine bitmaps and a runtime image switch, which this change does not do.

@xvcezrqpbxtpzblrt

Copy link
Copy Markdown
Contributor Author

Superseded by #4606, which carries this change with the rest of the 0.2.7 branch. Closing so the review has one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant