Repository navigation
[GUI] The installer speaks the nine languages of the app - #4456
Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
xvcezrqpbxtpzblrt wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #4606, which carries this change with the rest of the 0.2.7 branch. Closing so the review has one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The app speaks nine languages; its installer spoke one.
bundle.windows.nsis.languagesheld["English"], the template's own copy (welcome, finish, folder page, uninstall data page) was hardcoded English, and the welcome sidebar picture hadState of the art. At home.baked into the bitmap. On a Chinese Windows 11 the installer opened in English.Result
Validation
<Language>.nshfiles and nineMUI_LANGUAGElines (English, SimpChinese, Japanese, German, Spanish, Russian, PortugueseBR, Korean, French).Strata 安装, "顶尖技术,就在家里。", Chinese body, buttons下一步(N)/取消(C), no English tagline in the picture;Strata 0.2.7 已经安装了。选择您要执行的操作,然后单击下一步继续。with添加/重新安装and卸载 Strata;选择 Strata 的安装位置, "C 盘空间不足时,可以换一个磁盘。", and the custom top text in Chinese; no unresolved language reference anywhere.Limits