Repository navigation
[GUI] Open on the models this computer already has, not a false setup screen - #4462
Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
xvcezrqpbxtpzblrt wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #4606, which carries this change with the rest of the 0.2.7 branch. Closing so the review has one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every start opened the Models page on a screen that was not true:
A few seconds later the page jumped to the installed model. The cause is in the host: its first snapshot says
available: falsewith the sentence "Connect a local Strata installation" before it has read anything, and the first read of the installation can take many seconds (measured here: the first/api/nativeanswer came after about 30 s on a cold start). The page could not tell "not read yet" from "nothing installed", so it rendered the setup state.Result
checking: trueuntil the first look at the installation ends;available: falsebefore that no longer claims "nothing is installed".native-snapshot.json(only when it changes) and loaded at the next start, so the page opens on the models this computer already has while the fresh read runs behind it. A model deleted outside Strata disappears when that read ends.Validation
/api/nativeright after start returned nothing for 30 s, and the Models page showed the setup card for that time.npm run typecheckclean;node --test tests/packaged-control.test.mjs tests/ui4-fixes.test.mjs→ 33 pass, 0 fail.Limits