Repository navigation
[GUI] The thinking row shows live time and tokens, and counts only the thinking - #4471
Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
Closed
xvcezrqpbxtpzblrt wants to merge 1 commit into
xvcezrqpbxtpzblrt wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #4606, which carries this change with the rest of the 0.2.7 branch. Closing so the review has one place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The thinking row above an answer had three faults:
Result
Thinking… 1m 20s · ≈3,120 tokens, one tick a second, nothing else in the chat re-renders.Thought for 5m 26s · ≈3,120 tokens, frozen.≈; the engine does not report a reasoning-only count.≈{0} tokenslabel; the existing "Thinking…" and "Thought for {0}" translations are reused.Validation
node --test tests/live-chat.test.mjs→ 17 pass, including: a running segment counts up, a closed message counts only closed time, two segments add instead of replacing, an idle message adds nothing, and the token estimate (CJK vs Latin vs empty).npm run typecheckclean; catalog tests (key sets, French typography, gaps) pass.思考中… 0s · 约 12 词元, then settled to推理 · 约 37 词元(Swift thought for under a second, so the "Thought for" form is not used); the long earlier answer now reads思考了 5m 26s · 约 40,403 词元.Limits