Conversation
Ben-Diehlci
pushed a commit
to Ben-Diehlci/altserver-linux
that referenced
this pull request
Sep 14, 2026
…actually needed The README had accumulated instructions that do not work and warnings that no longer apply, which is worse than having none. Corrected: - Build steps omitted `cd build`. makefiles/main.mak sets BUILD_DIR := $(CURDIR), so running make from the repo root builds into the wrong place. This is what upstream PR NyaMisty#124 fixes; it has been open since 2025. - The note telling ARM builders to remove -mno-default is STALE. The Makefile already guards that flag to i386/i686, so ARM builds work unmodified. Following the old advice means editing a file for no reason. - The corecrypto instructions describe a distribution Apple no longer ships. They tell you to delete lines from a generated Makefile2 that the current archive never gets far enough to produce. Replaced with a pointer to buildenv/Dockerfile, which is verified to work, plus the three actual problems and the fact that the visible error ("No SOURCES given to target") is a follow-on rather than the real one. Added: - A quick-start using the container and the Portainer stack, which is now the simplest path and did not exist before. - A runtime requirements table. The binary alone is not enough, and three of the requirements used to fail silently -- notably libavahi-compat-libdnssd-DEV rather than -libdnssd1, which is the single most likely way to end up with a server that runs, reports nothing wrong, and cannot be discovered. - A pointer to the easier build route: the same prebuilt alpine toolchain CI uses, rather than assembling corecrypto/cpprestsdk/boost/libzip by hand. - Links to BOOTSTRAP.md, REVIVAL.md and deploy/, so someone arriving at this fork can find the setup runbook and the record of what changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Ben-Diehlci
pushed a commit
to Ben-Diehlci/altserver-linux
that referenced
this pull request
Sep 15, 2026
…actually needed The README had accumulated instructions that do not work and warnings that no longer apply, which is worse than having none. Corrected: - Build steps omitted `cd build`. makefiles/main.mak sets BUILD_DIR := $(CURDIR), so running make from the repo root builds into the wrong place. This is what upstream PR NyaMisty#124 fixes; it has been open since 2025. - The note telling ARM builders to remove -mno-default is STALE. The Makefile already guards that flag to i386/i686, so ARM builds work unmodified. Following the old advice means editing a file for no reason. - The corecrypto instructions describe a distribution Apple no longer ships. They tell you to delete lines from a generated Makefile2 that the current archive never gets far enough to produce. Replaced with a pointer to buildenv/Dockerfile, which is verified to work, plus the three actual problems and the fact that the visible error ("No SOURCES given to target") is a follow-on rather than the real one. Added: - A quick-start using the container and the Portainer stack, which is now the simplest path and did not exist before. - A runtime requirements table. The binary alone is not enough, and three of the requirements used to fail silently -- notably libavahi-compat-libdnssd-DEV rather than -libdnssd1, which is the single most likely way to end up with a server that runs, reports nothing wrong, and cannot be discovered. - A pointer to the easier build route: the same prebuilt alpine toolchain CI uses, rather than assembling corecrypto/cpprestsdk/boost/libzip by hand. - Links to BOOTSTRAP.md, REVIVAL.md and deploy/, so someone arriving at this fork can find the setup runbook and the record of what changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corrected instructions to cd into build directory before running make, and get the number of threads available from nproc.