Conversation
|
Small note for arch linux users: You can also install libcorecrypto-git from the aur - which automatically applies the required fixes mentioned here |
Ben-Diehlci
pushed a commit
to Ben-Diehlci/altserver-linux
that referenced
this pull request
Sep 14, 2026
…yaMisty#111) The buildenv image has not been rebuildable for some time. Three independent problems stack up; this fixes the first two. The image still does not build, so NyaMisty#111 stays open -- but each fix was needed to reveal the next, and both are confirmed against a real build rather than reasoned about. 1. Apple versioned the archive's top-level directory. corecrypto.zip now extracts to corecrypto-2024/, not corecrypto/. The download and unzip were always fine; the failure was purely a path mismatch, made invisible by Docker's WORKDIR silently CREATING the missing /buildenv/corecrypto, so the error surfaced one line later as the confusing "source directory does not appear to contain CMakeLists.txt". Renamed version-agnostically rather than hardcoding -2024, and a `test -f corecrypto/CMakeLists.txt` now fails loudly at the real cause if Apple renames it again. 2. Apple's CMakeLists.txt include()s scripts/code-coverage.cmake, which the distribution does not ship -- scripts/ contains only the testvector converters. This is exactly what upstream PR NyaMisty#85 diagnosed in December 2022 ("isn't really relevant for our use") and it was never merged. CODE_COVERAGE is off by default, so the include at line 63 is the only reference that actually breaks configure; the uses at lines 106 and 359 are already guarded. STILL BROKEN, not addressed here: with both fixes applied, cmake now configures far enough to fail at CMakeLists.txt:266 with "No SOURCES given to target: corecrypto_static". CORECRYPTO_SRCS is populated at CoreCryptoSources.cmake:189, and the Linux branch subtracts CORECRYPTO_EXCLUDE_SRCS at line 262; something in that interaction empties the list on the 2024 distribution. That is Apple's CMake, not ours, and needs its own investigation. None of this blocks the main build, which pulls the prebuilt ghcr.io/nyamisty/altserver_builder_alpine_* images -- all four verified still publicly pullable, and all four legs currently build green against them. What is broken is only the ability to rebuild those images from source, which is a bus-factor risk rather than an outage. Verified by building the Dockerfile through the cmake step for arm64v8/alpine:3.15 under Colima; error 1 and error 2 each confirmed present before the fix and absent after. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Ben-Diehlci
pushed a commit
to Ben-Diehlci/altserver-linux
that referenced
this pull request
Sep 14, 2026
The full corecrypto make and make install now exit 0 in the alpine builder, so this is no longer "configure passes, rest unknown". All three layers are fixed: the corecrypto-2024 directory rename, the missing scripts/code-coverage.cmake include (upstream PR NyaMisty#85's diagnosis, unmerged since December 2022), and the stale corecrypto_static/ccrng_static.c path in Apple's own source list. The buildenv image can be rebuilt from source again, which it could not for roughly four years. That matters beyond the issue: the whole build depends on four prebuilt ghcr.io images that nobody could reproduce, so this removes a real bus-factor risk rather than just closing a ticket. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Ben-Diehlci
pushed a commit
to Ben-Diehlci/altserver-linux
that referenced
this pull request
Sep 15, 2026
The full corecrypto make and make install now exit 0 in the alpine builder, so this is no longer "configure passes, rest unknown". All three layers are fixed: the corecrypto-2024 directory rename, the missing scripts/code-coverage.cmake include (upstream PR NyaMisty#85's diagnosis, unmerged since December 2022), and the stale corecrypto_static/ccrng_static.c path in Apple's own source list. The buildenv image can be rebuilt from source again, which it could not for roughly four years. That matters beyond the issue: the whole build depends on four prebuilt ghcr.io images that nobody could reproduce, so this removes a real bus-factor risk rather than just closing a ticket. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent distribution of
core-cryptoassumes the presence of a code coverage scriptscripts/code-coverage.cmake. This causescmaketo fail and isn't really relevant for our use.I've changed the build steps to include removing references to code-coverage. Everything builds successfully after that.