Skip to content

[18.0][FIX] queue_job: tests were partly skipped due to indentation #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 1 commit into from
Sep 22, 2026
+5 −5
Merged

[18.0][FIX] queue_job: tests were partly skipped due to indentation #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion queue_job/tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from . import test_run_rob_controller
from . import test_run_job_controller
from . import test_runner_channels
from . import test_runner_runner
from . import test_delayable
Expand Down
8 changes: 4 additions & 4 deletions queue_job/tests/test_run_rob_controller.py → queue_job/tests/test_run_job_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,23 +38,23 @@ def test_runjob_on_fail(self):
function.on_fail_method = "_test_on_fail"
job = self.env["queue.job"].with_delay()._test_job(failure_rate=1)
with (
self.assertRaises(JobError),
patch(
"odoo.addons.queue_job.models.queue_job.QueueJob._test_on_fail"
) as mocked_hook,
patch("odoo.addons.queue_job.job.Job.in_temporary_env") as mocked_temp_env,
self.assertRaises(JobError),
mute_logger("odoo.addons.queue_job.controllers.main"),
):
mocked_temp_env.return_value.__enter__.return_value = self.env
RunJobController._runjob(self.env, job)
self.assertEqual(job.state, "failed")
self.assertEqual(mocked_hook.call_count, 1)
self.assertEqual(job.state, "failed")
self.assertEqual(mocked_hook.call_count, 1)

def test_runjob_on_fail_not_configured(self):
job = self.env["queue.job"].with_delay()._test_job(failure_rate=1)
with (
self.assertRaises(JobError),
patch("odoo.addons.queue_job.job.Job.in_temporary_env") as mocked_temp_env,
self.assertRaises(JobError),
mute_logger("odoo.addons.queue_job.controllers.main"),
):
mocked_temp_env.return_value.__enter__.return_value = self.env
Expand Down
Loading