[18.0][ADD] report_wkhtmltopdf_local_assets - #1196
Open
marcos-mendez wants to merge 1 commit into
Open
marcos-mendez wants to merge 1 commit into
marcos-mendez wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:18.0
mod:report_wkhtmltopdf_local_assets
marcos-mendez
force-pushed
the
18.0-add-report_wkhtmltopdf_local_assets
branch
from
September 14, 2026 13:33
43efd7f to
952a8ab
Compare
wkhtmltopdf fetches stylesheets, scripts, fonts and images over HTTP from the workers that are waiting for it. Once every worker is rendering a PDF, the asset requests queue behind them and the instance stops answering (odoo/odoo#199880). Rewrite the report HTML before calling wkhtmltopdf: static files are referenced from disk, anything else served by the instance is resolved in-process and written to a temporary directory. Local file access stays disabled; only the directories involved are passed with --allow.
marcos-mendez
force-pushed
the
18.0-add-report_wkhtmltopdf_local_assets
branch
from
September 14, 2026 13:34
952a8ab to
f2fa7b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feed wkhtmltopdf with local files instead of HTTP round-trips to the Odoo workers.
wkhtmltopdf fetches the report assets from the same workers that are waiting for it; once every worker is rendering a PDF the instance deadlocks (odoo/odoo#199880, still open). Static files are referenced from disk, anything else served by the instance is resolved in-process and written to a temporary directory. Local file access stays disabled, only the directories involved are passed with
--allow.Core fix proposed in odoo/odoo#287921.