[19.0][FIX] endpoint_route_handler: precompute=True on route field - #136
Merged
Merged
Conversation
Contributor
|
Hi @simahawk, |
OCA-git-bot
added
series:19.0
mod:endpoint_route_handler
AungKoKoLin1997
force-pushed
the
19.0-fix-endpoint_route_handler
branch
from
May 26, 2026 04:53
b81ed4d to
1d55f71
Compare
smorita7749
approved these changes
Jun 1, 2026
smorita7749
left a comment
smorita7749
left a comment
There was a problem hiding this comment.
Functional review: LGTM
The error is fixed.
Contributor
|
This PR has the |
simahawk
reviewed
Jul 1, 2026
AungKoKoLin1997
force-pushed
the
19.0-fix-endpoint_route_handler
branch
from
July 22, 2026 10:04
1d55f71 to
fb83e40
Compare
simahawk
approved these changes
Sep 15, 2026
simahawk
left a comment
simahawk
left a comment
Contributor
There was a problem hiding this comment.
@AungKoKoLin1997 can you backport to v18 pls?
Contributor
Author
Without precompute, the required computed field is evaluated after INSERT (during flush), so creating an endpoint whose route is derived from other fields by a downstream module fails with "Missing required value for the field 'Route'" — the INSERT runs before the compute can populate the column.
AungKoKoLin1997
force-pushed
the
19.0-fix-endpoint_route_handler
branch
from
September 16, 2026 02:56
fb83e40 to
ecba2c0
Compare
Contributor
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at dfb4f9c. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #135
Without precompute, the required computed field is evaluated after INSERT (during flush), so creating an endpoint whose route is derived from other fields by a downstream module fails with "Missing required value for the field 'Route'" — the INSERT runs before the compute can populate the column.
@qrtl QT6769