Skip to content

minor adaptations for rebuttal - #173

Open
oliverchampion wants to merge 2 commits into
mainfrom
Rebuttal_OGC
Open

oliverchampion wants to merge 2 commits into
mainfrom
Rebuttal_OGC

Conversation

@oliverchampion

Copy link
Copy Markdown
Collaborator

Describe the changes you have made in this PR

Expanded osipibase.cite and added note about licenses.

Checklist

  • [ x ] Self-review of changed code
  • [ x ] Added automated tests where applicable
  • [ x ] Update Docs & Guides

@IvanARashid IvanARashid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small things.

I really like the methods report!

Comment thread src/wrappers/OsipiBase.py Outdated
Comment thread src/wrappers/OsipiBase.py Outdated
@oliverchampion

Copy link
Copy Markdown
Collaborator Author

I think these issues are now resolved

@oscarjalnefjord

Copy link
Copy Markdown
Collaborator

Looks fine to me. You might want to add units för D and Dp as it is printed for the b-values.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants