Repository navigation
Avoid duplicate languages in edition metadata - #3699
Closed
prajakta128 wants to merge 1 commit into
Closed
prajakta128 wants to merge 1 commit into
prajakta128 wants to merge 1 commit into
Conversation
Collaborator
|
This is by design. Not all bersions has the same number of languages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeckService.getLanguages() was collecting languages from every version of an
edition, so languages shared by multiple versions appeared more than once.
For example, the webapp metadata listed 21 entries for only 12 languages.
This change removes the duplicates while keeping the first occurrence of each
language. I also added a regression test for the webapp edition.
Resolved or fixed issue: none
Testing: