Repository navigation
grafana: allow the plugins Grafana 13 preinstalls in security-check.sh - #510
Merged
Merged
Conversation
Grafana 13 downloads and keeps updating 18 plugins on every start, including core datasources it now ships separately (prometheus, tempo, elasticsearch, ...). On an untouched pre-hardening install, 12 of them are in data/grafana/plugins, so the check reported 8 false findings. Use Grafana's full preinstall list, taken from the "Installing plugins" line in Grafana 13.2.4's startup log. An untouched install now reports no issues, while a planted service account and plugin are still flagged.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the main PR (01a9b19) onto
main-v1.11forv1.11.4.grafana/security-check.shexpected only four Grafana apps indata/grafana/plugins, but Grafana 13 preinstalls and keeps updating 18 plugins there, including core datasources it now ships separately. Every upgraded node got 8 false findings and was told to report them. This uses Grafana's full preinstall list, from the "Installing plugins" line of Grafana 13.2.4's startup log.Tested against an untouched install with all 18 plugin directories (no issues, exit 0) and a tampered one with a planted service account, token, datasource and
yesoreyeram-infinity-datasourceplugin (all four flagged, exit 1). The change is identical to the one onmain.category: bug
ticket: none