ci: publish gloas docker image tag - #4677
Conversation
|
There was a problem hiding this comment.
🟢 Approval recommended
The workflow changes correctly mirror the existing electra tagging behavior and cleanly prevent gloas builds from overwriting main’s version-tagged image.
Pull request overview
Updates the Docker image publishing workflow so that pushes to the gloas branch produce a dedicated :gloas image tag (DockerHub + GHCR), aligned with the existing electra branch behavior, while preventing gloas builds from overwriting the version-based ($APP_VERSION) branch tag used by mainline builds.
Changes:
- Add
gloasto the workflow’s branch push triggers. - Publish a
gloasDocker tag only when the ref isrefs/heads/gloas. - Exclude the
gloasbranch from publishing the$APP_VERSIONbranch tag (likeelectra).
File summaries
| File | Description |
|---|---|
| .github/workflows/build-push-deploy.yml | Adds gloas branch trigger and tag rules, and prevents gloas builds from publishing the $APP_VERSION branch tag. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4677 +/- ##
==========================================
- Coverage 65.40% 65.36% -0.04%
==========================================
Files 247 247
Lines 29983 29983
==========================================
- Hits 19609 19599 -10
- Misses 10373 10383 +10
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|



Publish
obolnetwork/charon:gloas(and ghcr) images on pushes to thegloasbranch, mirroring the existingelectratag rule. The gloas branch is excluded from the$APP_VERSIONtag so its builds don't overwrite main's version-tagged image. The gloas branch picks the workflow up on its next rebase onto main.category: misc
ticket: #4324