Skip to content

ci: publish gloas docker image tag - #4677

Open
KaloyanTanev wants to merge 1 commit into
mainfrom
kalo/gloas-docker-tag
Open

ci: publish gloas docker image tag#4677
KaloyanTanev wants to merge 1 commit into
mainfrom
kalo/gloas-docker-tag

Conversation

@KaloyanTanev

Copy link
Copy Markdown
Collaborator

Publish obolnetwork/charon:gloas (and ghcr) images on pushes to the gloas branch, mirroring the existing electra tag rule. The gloas branch is excluded from the $APP_VERSION tag so its builds don't overwrite main's version-tagged image. The gloas branch picks the workflow up on its next rebase onto main.

category: misc
ticket: #4324

@KaloyanTanev KaloyanTanev self-assigned this Sep 2, 2026
@KaloyanTanev
KaloyanTanev requested a lite review from Copilot September 2, 2026 10:54
@sonarqubecloud

sonarqubecloud Bot commented Sep 2, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow changes correctly mirror the existing electra tagging behavior and cleanly prevent gloas builds from overwriting main’s version-tagged image.

Pull request overview

Updates the Docker image publishing workflow so that pushes to the gloas branch produce a dedicated :gloas image tag (DockerHub + GHCR), aligned with the existing electra branch behavior, while preventing gloas builds from overwriting the version-based ($APP_VERSION) branch tag used by mainline builds.

Changes:

  • Add gloas to the workflow’s branch push triggers.
  • Publish a gloas Docker tag only when the ref is refs/heads/gloas.
  • Exclude the gloas branch from publishing the $APP_VERSION branch tag (like electra).
File summaries
File Description
.github/workflows/build-push-deploy.yml Adds gloas branch trigger and tag rules, and prevents gloas builds from publishing the $APP_VERSION branch tag.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@KaloyanTanev
KaloyanTanev enabled auto-merge (squash) September 2, 2026 10:56
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.36%. Comparing base (a67667d) to head (f3085ac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4677      +/-   ##
==========================================
- Coverage   65.40%   65.36%   -0.04%     
==========================================
  Files         247      247              
  Lines       29983    29983              
==========================================
- Hits        19609    19599      -10     
- Misses      10373    10383      +10     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants