Remove old nav code, make the new nav the default - #3381
Merged
Conversation
rosslovas
force-pushed
the
ross/default-new-top-nav
branch
from
August 18, 2026 23:27
0f367a1 to
9317f3b
Compare
|
Pull request environment is available at https://stoctodocspr3381.z22.web.core.windows.net. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
rosslovas
force-pushed
the
ross/default-new-top-nav
branch
from
August 18, 2026 23:50
9317f3b to
d3bb78a
Compare
rosslovas
force-pushed
the
ross/default-new-top-nav
branch
from
August 19, 2026 00:21
d3bb78a to
4972472
Compare
rosslovas
marked this pull request as ready for review
August 19, 2026 00:38
borland
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We've been able to try out the new nav for a while with
?newnavappended to the URL, but the old header was still the experience customers saw, as the new nav was missing functionality.I believe at this point the new nav has everything we need, so this PR attempts to delete all the code related to the old header, and makes the new header the default.
Results
Test it out at: https://stoctodocspr3381.z22.web.core.windows.net/docs
To test the signed-in state:
(revert to the signed-out state with:)
Note that there are two relatively distinct experiences worth testing: the ordinary wide experience, and the mobile-friendly experience that appears when the viewport is less than 1130px wide.