Delete the unused split button script - #3383
Merged
Merged
Conversation
src/scripts/split-button.ts is not imported anywhere, and the selectors it matches ([data-split-menu] and [data-split-trigger]) are not rendered by any component. Menu.astro handles this behaviour through src/scripts/menu.ts instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Pull request environment is available at https://stoctodocspr3383.z22.web.core.windows.net. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
enf0rc3
marked this pull request as ready for review
August 19, 2026 02:04
rosslovas
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/scripts/split-button.tsis dead code. Nothing imports it, and the selectors it matches ([data-split-menu],[data-split-trigger]) are not rendered by any component.Menu.astroimportssrc/scripts/menu.ts, which matches[data-menu].Split out of NES-294, which noticed it.
🤖 Generated with Claude Code