fix(sni-connect): add shared request admission queue - #81
Open
huhuanming wants to merge 5 commits into
Open
Conversation
huhuanming
marked this pull request as ready for review
August 3, 2026 15:46
originalix
reviewed
Aug 3, 2026
originalix
reviewed
Aug 3, 2026
originalix
reviewed
Aug 3, 2026
originalix
reviewed
Aug 3, 2026
originalix
reviewed
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestId, per-runtime cancellation APIs, and debug snapshots to the public SNI JS/native API3.0.81and document the release inCHANGELOG.mdWhy
The app-monorepo currently carries these SNI request-queue and cancellation behaviors as a package patch. Moving them into the maintained package source removes that patch dependency and ensures main/background React Native runtimes share capacity while retaining cancellation ownership per runtime.
Impact
@onekeyfe/react-native-sni-connect@3.0.81and remove the downstream patchValidation
corepack yarn install --immutable? passedcorepack yarn workspace @onekeyfe/react-native-sni-connect prepare? passedcorepack yarn workspace @onekeyfe/react-native-sni-connect typecheck? passedcorepack yarn workspace @onekeyfe/react-native-sni-connect test --runInBand? passed (6/6)corepack yarn workspace @onekeyfe/react-native-sni-connect test:android? passed (19/19)swift test? passed (20/20)BUILD SUCCEEDED)RCT_NEW_ARCH_ENABLED=0git diff --check? passedThe iOS runtime harness does not cover real-network
cancelAllRequests, response-body cancellation, cross-runtime ownership, or duplicate-ID replacement; those paths were source-reviewed and compiled under New Architecture.Publishing
@onekeyfe/react-native-sni-connect@3.0.81.3.0.81.3.0.81was rejected as a duplicate; its log contains 34 successful publishes and no other npm error.latest=3.0.81.