Repository navigation
feat: follow the anchor on scroll and lock the page behind a modal - #28
Merged
Merged
Conversation
An anchored popover used to be clamped into the viewport, so it detached from its anchor and parked on the edge once the page scrolled. Only the cross axis is clamped now, and never past the anchor itself, so the popover stays attached wherever the anchor goes. Modal dialogs now freeze the page behind them by default. Compensating for the missing scrollbar with padding only works for in-flow content, so a fixed nav still jumped 15px sideways; the gutter is reserved with scrollbar-gutter instead, which fixed elements respect too, with the old padding kept as a fallback. Locks are reference counted so a stack of modals releases the page only when the last one closes. Also fixes the docs ajax example, which called setLoading on the promise returned by show() instead of on the dialog, and rewrites the README around the documentation site, with a Traditional Chinese translation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An anchored popover used to be clamped into the viewport, so it detached from its anchor and parked on the edge once the page scrolled. Only the cross axis is clamped now, and never past the anchor itself, so the popover stays attached wherever the anchor goes.
Modal dialogs now freeze the page behind them by default. Compensating for the missing scrollbar with padding only works for in-flow content, so a fixed nav still jumped 15px sideways; the gutter is reserved with scrollbar-gutter instead, which fixed elements respect too, with the old padding kept as a fallback. Locks are reference counted so a stack of modals releases the page only when the last one closes.
Also fixes the docs ajax example, which called setLoading on the promise returned by show() instead of on the dialog, and rewrites the README around the documentation site, with a Traditional Chinese translation.