Repository navigation
Fix/scroll lock propagation target - #29
Merged
Merged
Conversation
The viewport reads its overflow from the root element, unless that computes to `visible`, in which case the value comes from <body>. Writing the lock onto <html> therefore switched the propagation source on any page that styles <body>, and <body> — which usually also has `height: 100%` — became a scroll container in its own right. The viewport's scrollable area collapsed to one screen, the browser clamped the offset to zero, and the page jumped to the top and stayed there after the dialog closed. The lock now lands on whichever element the viewport is already listening to, so nothing changes about which box scrolls. The scrollbar gutter stays on the root element, where it belongs either way. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.