Repository navigation
Conversation
Opt-in raise_errors raises EmoncmsAuthError on HTTP 401, EmoncmsConnectionError on client errors/timeouts and EmoncmsError otherwise, from async_request and async_input_post. Closes Open-Building-Management#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2. Stacked on that branch, so until #2 merges this diff also shows its commit; review only the last two commits (
feat: ship py.typed...,fix: stop configuring the root logger...). I'll rebase ontomainand mark ready once #2 merges.Summary
Makes the package PEP 561 typed so downstream users like Home Assistant can type-check against it, and stops it configuring logging on import.
The
logging.basicConfig()call moves into the README example so its debug output still prints.Evidence
feat/raise-errors):Merge Danger
Door: two-way
Blast Radius: small
logging.basicConfig()stop seeing its log output until they configure logging themselves.urlnow defaults to""instead ofNone. Every caller passes a URL, so in practice nothing changes.python_requires=">=3.9"now actually holds: onmainthe package fails to import on 3.9.