Repository navigation
Conversation
eliminate improper usage of CollectionMetadata
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
It introduces a breaking constructor signature and crashes platform inference for parameterized collections.
Review effort: Balanced
Findings: 2
Open (4)
What changed in this PR
Decouples cube metadata from collection metadata for issue #949.
Changes:
- Uses
CubeMetadatafor raster, vector, and local STAC cubes. - Infers spectral platforms from process-graph collection IDs.
- Documents remaining metadata coupling.
| File | Description |
|---|---|
openeo/rest/datacube.py |
Converts loaded collection metadata to cube metadata. |
openeo/rest/vectorcube.py |
Uses cube metadata for vector cubes. |
openeo/local/connection.py |
Uses cube metadata for local STAC loading. |
openeo/extra/spectral_indices/spectral_indices.py |
Infers platforms from collection nodes. |
openeo/metadata/__init__.py |
Documents metadata design debt. |
openeo/udf/udf_signatures.py |
Notes remaining collection metadata usage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| attrs[at] = str(attrs[at]) | ||
| metadata = CollectionMetadata( | ||
| attrs, | ||
| metadata = CubeMetadata( |
…IDs for platform inference' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #949