Skip to content

docs(DiagramLayout): a Layout that only folds or hides places nothing - #11

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
docs/diagram-layout-fold-only-layout
Open

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
docs/diagram-layout-fold-only-layout

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

The Layout doc comment now says when x and y are needed. A Layout that binds only collapsed or show… switches is legal and places nothing: it folds the element, or hides its compartments, where the view lays it out. x/y are needed only to place the element and go together: one coordinate alone is an error, and so is a size with no place.

metadata Layout about rover::chassis::drive { collapsed = true; }   // folds, places nothing
metadata Layout about rover::chassis::drive { x = 40; collapsed = true; }   // error: one coordinate
metadata Layout about rover::chassis::drive { width = 120; height = 60; }   // error: size without a place

OpenSysML has accepted fold-only Layouts since Open-MBEE/OpenSysML#1254. This note uses the same rules as that PR and its documentation (docs/project/diagram-layout-annotations.md, the "Limiting what a view draws" guide example).

Only the comment changed: no declarations and no engine-contract.json entries. The collapsed attribute has no doc comment of its own, so it was left as it is.

Semver impact: PATCH (doc-comment change only).

Checks run locally: ./scripts/validate-libraries.sh (pinned pilot, 0 errors, 0 warnings), ./scripts/check-engine-contract.sh --base origin/main (exit 0), ./scripts/check-readme-table.sh.

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/3089cc5b6fb74efcba6bc4b8f739a409
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/3089cc5b6fb74efcba6bc4b8f739a409?variant=devin
Requested by: @HuiJun

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review October 20, 2026 03:09
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

The advisory OpenSysML against these libraries job fails for a reason that has nothing to do with this change. One test failed: TestKerMLFeatureMetaclassClassification in internal/semantic/semantics. It reads examples/pilot-corpora/kerml-examples/Vehicle Example/VehicleUsages.kerml, and this job does not download the OMG pilot corpora, so the file is missing.

The job on main fails the same way, on that test with that missing file. Every other package passes. The open ci/mirror-pilot-corpora PR (#10) adds the corpora download. This PR changes only one doc comment in DiagramLayout.sysml, and the required Validate the extension libraries check is green.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant