Repository navigation
refactor(runtime): split member chaining and bound-member collection into named steps - #1340
Merged
Merged
Conversation
…into named steps Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: jason.han <hanhuijun@gmail.com>
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Clears the SonarCloud findings on
developunderinternal/exec/runtime:go:S3776on(*Context).withBoundMembers(binding.go): the walk over an owner's types, their bindings and binding ends that names the members bound through a path is nowmembersBoundThrough;withBoundMemberskeeps the ownership walk and the held/added bookkeeping.go:S3776on(*EvalContext).chainMemberValue(eval.go): the array/vector/quantity/frame branch ischainThroughStructured, the object tail (reference value, shaped array, clock, feature value, variant) ischainObjectMember, and the fallbacks for a member no feature value holds (calc usage run, derived Kernel collection, holder default, Kernel member) arechainUnheldMember.godre:S8193insubsetting_test.go: a temporary that was only compared once is gone.Pure refactor with no behaviour change; the kernel of each helper is the code it replaced, moved verbatim. No changelog fragment.
Deferred from this group:
godre:S8196insolve/differential_test.go, which #1312 edits; it lands after that PR.A pull request gets no SonarCloud analysis (the CircleCI
scanjob runs ondevelopandmainonly); the proof that these findings clear is the post-merge scan ofdevelop.How it was verified
gofmt -l .empty,go build ./...,go vet ./...,make lint,go test ./internal/exec/runtime ./tests/hygienepass locally (the pilot-corpora gated tests skip without the corpora). The SonarCloud analyzer run over the edited files reports nogo:S3776on the three functions any more.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c2b1ac4ad6de4d8788e78fd86c7c1729
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c2b1ac4ad6de4d8788e78fd86c7c1729?variant=devin
Requested by: @HuiJun
Overlap with the open perf PRs
Dry-merged against the current heads of #1347 (
perf/memoize-expression-footprints, 2cff947), #1348 (perf/enumerate-children-without-route-walks, 22a1a46) and #1349 (perf/conform-by-symbol, 55b542a, stacked on #1348): all three merge clean with no textual conflict, and the merged trees build, passgo vetoninternal/semantic/...andinternal/exec/runtime, and pass the model tests. No merge commit was needed; if one of those heads moves onto the same lines before this merges, the resolution is a merge of that head, not a redo of its change.